Fix the remaining provider issues + upgrade init to 0.5.4 #3506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Fixes compatibility issues with provider logs during upgrade tests and updates the init image version.
- Adds fallback to read legacy provider logs if journalctl has no entries
- Improves test assertions by including the raw output on failure
- Bumps
KAIROS_INITin the Dockerfile from v0.5.3 to v0.5.4
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/provider_upgrade_latest_k8s_test.go | Add fallback logic to read /var/log/kairos/provider-*.log when journalctl has no entries |
| tests/provider_upgrade_k8s_test.go | Enhance Expect call to include resultStr in the failure message |
| images/Dockerfile | Upgrade KAIROS_INIT argument to v0.5.4 |
Comments suppressed due to low confidence (1)
images/Dockerfile:2
- [nitpick] Consider adding a brief comment or link to the changelog explaining why
KAIROS_INITwas bumped to v0.5.4, to help future maintainers understand the change.
ARG KAIROS_INIT=v0.5.4
mudler
approved these changes
Jul 1, 2025
mauromorales
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the latest provider issues and opensuse issues