Check that the ssh host fingerprint hasn't changed after upgrade #3498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3374 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
3374-test-ssh-host-fingerprint
branch
from
d3b0189 to
2d62df3
Compare
mauromorales
reviewed
Jul 1, 2025
tests/upgrade_cli_test.go
Outdated
| @@ -70,6 +78,18 @@ var _ = Describe("k3s upgrade manual test", Label("upgrade-with-cli"), func() { | |||
| return err | |||
| }, 10*time.Minute, 10*time.Second).ShouldNot(HaveOccurred()) | |||
|
|
|||
| // Get SSH host key fingerprint after upgrade | |||
| By("Getting SSH host key fingerprint after upgrade") | |||
| postUpgradeFingerprint, err := vm.Sudo("cat /etc/ssh/ssh_host_*.pub 2>/dev/null | ssh-keygen -lf -") | |||
There was a problem hiding this comment.
I know the go way is very verbose, but I wouldn't mind if this was a shared function accross these test files. Not bloking the pr
There was a problem hiding this comment.
Good point, let me give it a shot.
There was a problem hiding this comment.
ok pushed, let's see if I broke it :D
mauromorales
approved these changes
Jul 1, 2025
Signed-off-by: Dimitris Karakasilis <[email protected]>
otherwise it's nil Signed-off-by: Dimitris Karakasilis <[email protected]>
github-project-automation
bot
moved this from Under review 🔍
to Done ✅
in 🧙Issue tracking board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3374
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #