This repository was archived by the owner on Mar 2, 2022. It is now read-only.
Make parsing restic output resilient to non-json output #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
suggested changes
Mar 29, 2021
cimnine
force-pushed
the
ResilientLogging
branch
from
f9cb602 to
8bc6aaa
Compare
cimnine
force-pushed
the
ResilientLogging
branch
from
8bc6aaa to
bb8b30b
Compare
|
LGTM Just curious: how did you trigger the out of bounds in the snapshot parsing? |
Kidswiss
approved these changes
Mar 29, 2021
|
The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the parsing logic for parsing the restic output.
When some output can't be parsed as JSON, then it will still be written to the log, but it will not stop the processing of the output, as it did before.
As discussed in #79 (comment)