This repository was archived by the owner on Mar 2, 2022. It is now read-only.
Fix/ignore stdin progress #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
force-pushed
the
fix/ignore_stdin_progress
branch
from
930fa7f to
c883d4a
Compare
Kidswiss
force-pushed
the
fix/ignore_stdin_progress
branch
from
c883d4a to
724b0d1
Compare
|
#27 merged and rebased. |
corvus-ch
suggested changes
Oct 26, 2020
There was a problem hiding this comment.
Having the percentage printer functions attache BackupOutputParser is weird.
I suggest to change the function signature to type PercentageFunc func(logr.InfoLogger, float64). Make the implementations stand alone. The can be exported and thus become public API.
Kidswiss
force-pushed
the
fix/ignore_stdin_progress
branch
from
724b0d1 to
f8352d2
Compare
corvus-ch
approved these changes
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will stop printing unnecessary percentage information for stdin backups.
It's already using the changes made in #27 cause the logging was refactored quite a bit. So #27 should be merged first.
Closes: #26