-
Notifications
You must be signed in to change notification settings - Fork 80
Pin to an older version of Ginkgo and change builder image #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin to an older version of Ginkgo and change builder image #373
Conversation
This is the last version compatible with 1.18. Signed-off-by: Petr Horacek <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Stream 8 seems to be offline and we fail to pull RPMs from the repositories. Using dedicated Go base image instead. Signed-off-by: Petr Horacek <[email protected]>
a37577c
to
0982543
Compare
/cherry-pick release-0.31 |
@phoracek: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f7159f7
into
k8snetworkplumbingwg:release-0.32
@phoracek: #373 failed to apply on top of branch "release-0.29":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@phoracek: new pull request created: #378 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This is the last version compatible with 1.18. Not pinning pulls a version requiring 1.22. This will be later backported down to 0.29.
Stream 8 seems to be offline and we fail to pull RPMs from the repositories. This PR replaces Stream 8 by a dedicated Go 1.18 build image.
Special notes for your reviewer:
These two must be bundled together, otherwise one fails without the other.
Release note: