Skip to content

Pin to an older version of Ginkgo and change builder image #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

phoracek
Copy link
Member

@phoracek phoracek commented Mar 10, 2025

What this PR does / why we need it:

This is the last version compatible with 1.18. Not pinning pulls a version requiring 1.22. This will be later backported down to 0.29.

Stream 8 seems to be offline and we fail to pull RPMs from the repositories. This PR replaces Stream 8 by a dedicated Go 1.18 build image.

Special notes for your reviewer:

These two must be bundled together, otherwise one fails without the other.

Release note:

NONE

This is the last version compatible with 1.18.

Signed-off-by: Petr Horacek <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 10, 2025
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
@phoracek phoracek changed the title Pin to an older version of Ginkgo Pin to an older version of Ginkgo and bump builder image Mar 10, 2025
Stream 8 seems to be offline and we fail to pull RPMs from the
repositories.

Using dedicated Go base image instead.

Signed-off-by: Petr Horacek <[email protected]>
@phoracek phoracek changed the title Pin to an older version of Ginkgo and bump builder image Pin to an older version of Ginkgo and change builder image Mar 10, 2025
@phoracek
Copy link
Member Author

/cherry-pick release-0.31
/cherry-pick release-0.29

@kubevirt-bot
Copy link
Collaborator

@phoracek: once the present PR merges, I will cherry-pick it on top of release-0.29, release-0.31 in new PRs and assign them to you.

In response to this:

/cherry-pick release-0.31
/cherry-pick release-0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@phoracek phoracek merged commit f7159f7 into k8snetworkplumbingwg:release-0.32 Mar 20, 2025
3 of 4 checks passed
@kubevirt-bot
Copy link
Collaborator

@phoracek: #373 failed to apply on top of branch "release-0.29":

Applying: Pin to an older version of Ginkgo
Applying: Change builder image
Using index info to reconstruct a base tree...
M	cmd/Dockerfile
Falling back to patching base and 3-way merge...
Auto-merging cmd/Dockerfile
CONFLICT (content): Merge conflict in cmd/Dockerfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Change builder image

In response to this:

/cherry-pick release-0.31
/cherry-pick release-0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Collaborator

@phoracek: new pull request created: #378

In response to this:

/cherry-pick release-0.31
/cherry-pick release-0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants