Skip to content

update deprecated api version #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2020
Merged

update deprecated api version #141

merged 2 commits into from
Nov 26, 2020

Conversation

pperiyasamy
Copy link
Collaborator

This updates ClusterRole/ClusterRoleBinding kind apiVersion into v1 because v1beta1
is already deprecated in K8s 1.17 and deployment of ovs-cni.yml throws below warning.

Warning: rbac.authorization.k8s.io/v1beta1 ClusterRole is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRole
Warning: rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding

Signed-off-by: Periyasamy Palanisamy [email protected]

@pperiyasamy
update deprecated apiVersion
a767c77 
Signed-off-by: Periyasamy Palanisamy <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 17, 2020
@pperiyasamy
Copy link
Collaborator Author

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 17, 2020
phoracek
phoracek requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are generated based on https://github.com/kubevirt/ovs-cni/blob/master/manifests/ovs-cni.yml.in#L81. Would you please update the source and run make manifests?

@pperiyasamy
update api version in manifest source file
3b22e83 
Signed-off-by: Periyasamy Palanisamy <[email protected]>
@pperiyasamy
Copy link
Collaborator Author

These files are generated based on https://github.com/kubevirt/ovs-cni/blob/master/manifests/ovs-cni.yml.in#L81. Would you please update the source and run make manifests?

ah! yes, now updated the source file as well.

@pperiyasamy
Copy link
Collaborator Author

/cc @JanScheurich

@kubevirt-bot
Copy link
Collaborator

@pperiyasamy: GitHub didn't allow me to request PR reviews from the following users: JanScheurich.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @JanScheurich

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@phoracek
Copy link
Member

Thanks!

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2020
@kubevirt-bot kubevirt-bot merged commit 6f16405 into k8snetworkplumbingwg:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek requested changes

@EdDev EdDev Awaiting requested review from EdDev

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pperiyasamy @kubevirt-bot @phoracek