[Backport release-1.33] Remove timeout from dynamic cluster config initializer #5882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some nodes, initializing the cluster configuration can take quite a while, especially during the initial bootstrap phase, if many user-supplied stacks are applied. Moreover, if the cluster has a stale leader lease, it will take at least 60 seconds until it gets reacquired by Kubernetes leader election, hence the existing 20 second timeout will lead to a crash loop. Remove the timeout completely and rely on external cancellation. Increase the log level for the error in the retry loop once every minute from debug to info so the retry loop is visible in non-debug logs without flooding them every second. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 05f7867)
16 tasks
twz123
added
bug
makhov
approved these changes
Jun 3, 2025
jnummelin
approved these changes
Jun 3, 2025
makhov
approved these changes
Jun 3, 2025
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.33, triggered by a label in #5873.See .