Improve debugging experience for k0s inttests #5878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanluisvaladas
force-pushed
the
dbg-inttests
branch
from
31e02c6 to
535b0c9
Compare
juanluisvaladas
force-pushed
the
dbg-inttests
branch
from
535b0c9 to
1d0a016
Compare
Implements an optional, heavier debug image with delve and strace, a way to replace the command in the BootlooseSuite for a debugging command and documents it. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
juanluisvaladas
force-pushed
the
dbg-inttests
branch
from
1d0a016 to
d5eab45
Compare
|
Closing and reopening to retrigger CI as github is having problems |
juanluisvaladas
commented
May 26, 2025
| # Determine the bootloose stamp dependency based on K0S_DEBUG | ||
| # Default to .bootloose-alpine.stamp (the "otherwise" case from the request) | ||
| BOOTLOOSE_STAMP_DEP := .bootloose-alpine.stamp | ||
| ifeq ($(K0S_DEBUG_TESTS),true) |
There was a problem hiding this comment.
Maybe we should rename this variable to DEBUG, which is used to build a non stripped k0s binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attaching a debugger or running the inttests with strace is super annoying and every time I need to do it I end up having to make a custom image and modifying the Bootloose suite or launching myself the k0s command. We should have a standardized way of doing this where we don't need to think and it's just a command to get that done.
This PR implements an optional, heavier debug image with delve and strace, a way to replace the command in the BootlooseSuite for a debugging command and documents it.
Type of change
How Has This Been Tested?
Checklist