-
Notifications
You must be signed in to change notification settings - Fork 413
Old renovate bot - Update etcd dependencies to ... #5865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e858a71
to
e96d1a3
Compare
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
I run the workflow manually after merging #5868 There are two interesting notes here: |
Looks like it doesn't run go mod tidy, which is odd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs go mod tidy
e96d1a3
to
5cf577b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, the PR looks good. However, we need to test it carefully because it's the first feature release in several years. Also, @jnummelin said he heard about some dragons hiding in the dark wrinkles of the upgrade path.
Also there is a breaking change in an API we use.
I'll close and reopen to force the CI to run to verify that the go mod tidy work actually worked entirely as we expected even though I checked it locally on my machine. |
As for the upgrade I did a quick reading on etcd documentation and I verified we aren't using any of the deprecated/removed flags. I believe all we need to do is: 1- Before starting etcd check if the cluster is healthy and the etcd version of the peers So assuming it's just what the docs say, it looks like most of the effort will be testing and documentation. |
5cf577b
to
52f710d
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
52f710d
to
1638fdf
Compare
Trying to do the same as for the old kine PR. Closing/renaming this, and deleting the branch, so that it gets recreated with the right user. |
This PR contains the following updates:
3.5.21
->3.6.0
v3.5.21
->v3.6.0
v3.5.21
->v3.6.0
v3.5.21
->v3.6.0
v3.5.21
->v3.6.0
v3.5.21
->v3.6.0
v3.5.21
->v3.6.0
Release Notes
etcd-io/etcd (etcd-io/etcd)
v3.6.0
Compare Source
Please check out CHANGELOG for a full list of changes. And make sure to read upgrade guide before upgrading etcd (there may be breaking changes).
For installation guides, please check out play.etcd.io and operating etcd. Latest support status for common architectures and operating systems can be found at supported platforms.
Linux
macOS (Darwin)
Docker
etcd uses
gcr.io/etcd-development/etcd
as a primary container registry, andquay.io/coreos/etcd
as secondary.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.