Skip to content

Remove storage parameter from DefaultClusterConfig #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 5, 2025

Description

The storage override occurs only during the initial loading of the node configuration, and can be modeled by applying the changes to the default configuration and then merging the user-provided configuration data into it.

Also remove ConfigFromReader: The function hid the fact that there was no benefit at all to providing the input as a reader. It merely used io.ReadAll to load the data into memory. Removing this, and exposing to callers the fact that the only supported input is just a byte slice, makes the code more straightforward.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The function hid the fact that there was no benefit at all to providing
the input as a reader. It merely used io.ReadAll to load the data
into memory. Removing this, and exposing to callers the fact that
the only supported input is just a byte slice, makes the code more
straightforward.

Signed-off-by: Tom Wieczorek <[email protected]>
…rConfig

The storage override occurs only during the initial loading of the node
configuration, and can be modeled by applying the changes to the default
configuration and then merging the user-provided configuration data
into it.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the remove-storage-param branch from e6c5afe to 775388f Compare February 5, 2025 12:03
@twz123 twz123 marked this pull request as ready for review February 5, 2025 15:38
@twz123 twz123 requested review from a team as code owners February 5, 2025 15:38
@twz123 twz123 requested review from ncopa and makhov February 5, 2025 15:38
@twz123 twz123 merged commit 9c30564 into k0sproject:main Feb 6, 2025
93 checks passed
@twz123 twz123 deleted the remove-storage-param branch February 6, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants