Remove storage parameter from DefaultClusterConfig #5514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The storage override occurs only during the initial loading of the node configuration, and can be modeled by applying the changes to the default configuration and then merging the user-provided configuration data into it.
Also remove
ConfigFromReader
: The function hid the fact that there was no benefit at all to providing the input as a reader. It merely usedio.ReadAll
to load the data into memory. Removing this, and exposing to callers the fact that the only supported input is just a byte slice, makes the code more straightforward.Type of change
How Has This Been Tested?
Checklist: