Skip to content

Fix timing issue in ap-removedapis inttest #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jnummelin
Copy link
Member

Description

There's a timing issue on the test:

  • we apply a test CRD; we also wait to see it in API
  • we apply a test CR; we do NOT wait to see this in API
  • apply plan --> the CR is not yet applied (it's created via manifest deployer
  • plan actually "succeeds" to a degree where the test expects it to actually fail

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jnummelin jnummelin requested a review from a team as a code owner May 2, 2024 11:06
@jnummelin jnummelin requested review from kke and juanluisvaladas May 2, 2024 11:06
@twz123 twz123 added bug Something isn't working area/smoke-tests backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch labels May 2, 2024
@jnummelin jnummelin merged commit ca40556 into k0sproject:main May 3, 2024
@jnummelin jnummelin deleted the fix/removed-apis-test-timign-issue branch May 3, 2024 07:54
@k0s-bot
Copy link
Contributor

k0s-bot commented May 3, 2024

Successfully created backport PR for release-1.29:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/smoke-tests backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants