OWA-107: Fix broken SCA flow payment finalization

[mirovladimitrovski]

Description

This PR solves OWA-107

Steps completed:

According to our definition of done, I have completed the following steps:

• Acceptance criteria met
• Unit tests added
• Docs updated (including config and env variables)
• Translations added
• UX tested
• Browsers / platforms tested
• Rebased & ready to merge without conflicts
• Reviewed own code

[github-actions]

Visit the preview URL for this PR (updated for commit 9641f2d):

https://ottwebapp--pr677-owa-107-sca-ppv-flow-u6gyrnzp.web.app

_{(expires Sat, 26 Apr 2025 12:44:21 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: c198f8a3a199ba8747819f7f1e45cf602b777529}

[ChristiaanScheermeijer]

Hi @mirovladimitrovski, I believe this fix is for JWP integrations only, should we handle this from the JWP integration instead of making it a separate component/modal?

I think if we do something like this in the JWPAccountService.ts together with the reload subscription it should work basically the same, right?

  private async handlePPVPaymentIntent(url: string) {
    const searchParams = new URLSearchParams(url.split('?')[1]);
    const paymentIntent = searchParams.get('payment_intent');

    if (paymentIntent) {
      await this.apiService.post<CommonResponse>('/payments', { pi_id: paymentIntent }, { withAuthentication: true });
    }
  }

  initialize = async (config: Config, url: string, _logoutFn: () => Promise<void>) => {
    const jwpConfig = config.integrations?.jwp;

    await this.handlePPVPaymentIntent(url);

[mirovladimitrovski]

Hi @mirovladimitrovski, I believe this fix is for JWP integrations only, should we handle this from the JWP integration instead of making it a separate component/modal?

I think if we do something like this in the JWPAccountService.ts together with the reload subscription it should work basically the same, right?

  private async handlePPVPaymentIntent(url: string) {
    const searchParams = new URLSearchParams(url.split('?')[1]);
    const paymentIntent = searchParams.get('payment_intent');

    if (paymentIntent) {
      await this.apiService.post<CommonResponse>('/payments', { pi_id: paymentIntent }, { withAuthentication: true });
    }
  }

  initialize = async (config: Config, url: string, _logoutFn: () => Promise<void>) => {
    const jwpConfig = config.integrations?.jwp;

    await this.handlePPVPaymentIntent(url);

This is a good idea actually, much lighter in code. I'll have it done shortly.

[mirovladimitrovski]

@ChristiaanScheermeijer
In practice, your suggestion introduces a different problem. The problem is that the confirmation request is done very early during the app's boot-up, before we're subscribed to the notification websocket that is supposed to notify us that access has been granted. I still think the idea is good though, so I'm working on solving the problem.

[AntonLantukh]

Did you try to reuse everything in FanalizeAdyenPayment except using a different method instead of a checkoutController.finalizeAdyenPayment one?

[mirovladimitrovski]

I did think it through and couldn't think of anything that would improve the reusability further than what it is with this PR. Do you have anything specific on your mind?