Skip to content

Fix / Generic consents validation message & show message after submission #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

langemike
Copy link
Collaborator

@langemike langemike commented Jun 12, 2024

I introduced a bug with this PR #537

Bug

After my change, the error message always showed up initially (before form submission) and I noticed that the <CustomRegisterField /> can be used for all types of fields. In the situation I tested it with I have only seen checkboxes.

Fix

I reused the already present (generic) field_required error message which equals the message "This field is required" without any specificity or guidance. It originally was "This field is required, please fill in {{field}} to continue.", but the field name can be "technical" such as "broadcaster_terms" which we considered an issue. We originally wanted the extra information (such as please fill in or check the box) to guide users, but keeping this intact for all types but this requires a lot of work and translation maintenance. In the end we think (and hope) the message is clear enough.

I also wrote an e2e test to prevent the bug from happening.

Ticket: https://videodock.atlassian.net/browse/OTT-1928

Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@royschut royschut changed the title Fix / Generic constents validation message & show message after submission Fix / Generic consents validation message & show message after submission Jun 12, 2024
Copy link
Collaborator

@royschut royschut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@royschut royschut merged commit 70c34c5 into jwplayer:develop Jun 12, 2024
9 checks passed
@royschut royschut deleted the fix/custom-registrationform-error-message branch June 12, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants