Skip to content

Fix / password button alignment and infinite scroller #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2024

Conversation

MelissaDTH
Copy link
Contributor

Description

We've completed some rework, resulting in the following 2 fixes:

Changes

  • fix(project): alignment of password toggle button
    • Fixes the alignment op the password toggle button. We adjust the width and height for the controls in the Input component if its either a div (e.g. prevalent in the credit card form) or button (e.g. prevalent in the shelf)
  • chore(project): default infinitescroll to not use window
    • This change will make the infinite scroller listen to browser events initiated from the parentNode instead of the window. This will make the infinite scroller more adaptable when used in different layouts.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@AntonLantukh AntonLantukh merged commit 17b9fca into jwplayer:develop May 6, 2024
8 of 9 checks passed
@royschut royschut deleted the fix/rework-sprint5-mh branch May 28, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants