Feat / subscription retry logic #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royschut
force-pushed
the
feat/subscription-retry-logic
branch
from
8b05c06 to
d0a4e42
Compare
royschut
requested review from
ChristiaanScheermeijer,
budzworthy and
AntonLantukh
ChristiaanScheermeijer
approved these changes
Apr 25, 2024
royschut
force-pushed
the
feat/subscription-retry-logic
branch
from
910518f to
f162661
Compare
AntonLantukh
reviewed
May 7, 2024
| @@ -34,7 +34,7 @@ const useOffers = () => { | |||
| const switchSubscription = useMutation({ | |||
| mutationKey: ['switchSubscription'], | |||
| mutationFn: checkoutController.switchSubscription, | |||
| onSuccess: () => accountController.reloadSubscriptions({ delay: 7500 }), // @todo: Is there a better way to wait? | |||
| onSuccess: () => accountController.reloadSubscriptions({ delay: 3000, retry: 10 }), // A subscription switch usually takes at least 3 secs | |||
There was a problem hiding this comment.
@royschut Will it work properly if we already have an "activeSubscription"? I mean the case here when we switch a subscription. So it looks like this condition !activeSubscription && !!retry && retry > 0 won't work.
There was a problem hiding this comment.
Good point, probably not. We could fix it using the approach proposed by @dbudzins in #483, but that's too large of a refactor for this moment. I have noted this for another moment.
But until that, for now I see two options:
- We set the initial delay for this case back to 7500, and merge this PR as it is still a step forward
- We set this PR back into Draft for now
I'm fine with both options. :)
There was a problem hiding this comment.
I am good with the first option. Just wanted to make sure this is something you are aware of.
AntonLantukh
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Copy of #483, which was automatically closed when its base PR (#494) was merged, and I couldn't reopen)
Access check retry mechanism
This PR adds a retry mechanism to the access check (
reloadActiveSubscription()), to make sure that the UI notices granted access, even if the backend takes longer to process a purchase. This also makes it possible to reduce the initial delay. Note: I've left the initial delay after a subscription switch on3000ms, because a switch presumably always takes long (it was initially set to7500).