Skip to content

[BUG] PiP not working on iOS #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Make iOS PiP work out of the box
  • Better define requirements for PiP
  • Safer handling of category and categoryOptions

Why is this Pull Request needed?

  • Make iOS PiP work again

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner September 25, 2024 15:24
Copy link
Contributor

@david-almaguer david-almaguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks good to me

@Jmilham21 Jmilham21 merged commit d3bb9b6 into master Sep 25, 2024
@Jmilham21 Jmilham21 deleted the bug/pip-not-working-on-ios branch September 25, 2024 16:57
@sedatb
Copy link

sedatb commented Dec 16, 2024

@Jmilham21 pip mode close button not working correctly. When I press button, pip disabled but video not showing. Only sound is coming (I observed on ios 18.1)

@MitchellVermaningSouthfields

@Jmilham21 pip mode close button not working correctly. When I press button, pip disabled but video not showing. Only sound is coming (I observed on ios 18.1)

Same here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants