Skip to content

fix: update TypeScript module to match package name #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024

Conversation

chriszs
Copy link
Contributor

@chriszs chriszs commented May 3, 2024

What does this Pull Request do?

Updates the TypeScript module name to match the package name.

Why is this Pull Request needed?

So that TypeScript can check this correctly.

Addresses Issue(s):

Closes #6

Copy link
Contributor

@david-almaguer david-almaguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks @chriszs !

@chriszs
Copy link
Contributor Author

chriszs commented May 4, 2024

Thanks! Looks like a maintainer has to do the merge.

@Jmilham21 Jmilham21 merged commit 1bf5354 into jwplayer:master May 7, 2024
@chriszs chriszs deleted the patch-1 branch May 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] index.d.ts declares module name without "@jwplayer"
3 participants