Fix unable to run on iOS simulator with ads turned on #50 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dominictobias It's okay to support patch versions since the public API of the GoogleIMA SDK wouldn't be affected. Thanks for addressing this. |
david-almaguer
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ability to run on an iOS Simulator with ads turned on #50
Could pin the version but this bug occurred because you didn't allow patch versions - up to you
P.S. Do I need to explicitly do something else to enable ads, like fill out
advertising?: JwAdvertisingConfiginJwConfig? The docs don't mention anything