Upgrade Example app to React-Native 0.78.1 #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Upgrades the React-Native Example application to version 0.78.1 via https://react-native-community.github.io/upgrade-helper/
Thought Process
.env
in.gitignore
reinstall
script inpackage.json
purge_modules
script inpackage.json
postinstall
script inpackage.json
postinstall-postinstall
dev dependency inpackage.json
react-native-dotenv
dev dependency inpackage.json
README.md
compileOptions
inapp/build.gradle
. I detected this was added by us and it is no longer present in the latest versioncopyDownloadableDepsToLibs
Gradle task fromapp/build.gradle
. I removed it since the helper removed other BUCK related filesapplyNativeModulesAppBuildGradle
at the end ofapp/build.gradle
def REACT_NATIVE_VERSION
frombuild.gradle
0.70.14
specific patchgoogle-cast-sdk
inRNJWPlayer.podspec
to4.8.3
in order to solve a bundling issue of the Privacy Manifest. Context: The new React-Native generates a Privacy Manifest file atpod install
which clashes with the one bundled bygoogle-cast-sdk
. Google released a fix for this in4.8.3
and it is now declared asresource_bundles
instead ofresources
in the Podspec file:Before: https://github.com/CocoaPods/Specs/blob/master/Specs/8/1/2/google-cast-sdk/4.8.1/google-cast-sdk.podspec.json
After: https://github.com/CocoaPods/Specs/blob/master/Specs/8/1/2/google-cast-sdk/4.8.3/google-cast-sdk.podspec.json)
Why is this Pull Request needed?
To keep up to date to the latest React-Native changes
Are there any points in the code the reviewer needs to double check?
Double check against https://react-native-community.github.io/upgrade-helper/
Are there any Pull Requests open in other repos which need to be merged with this?
No
Addresses Issue(s):
GitHub Issue