Skip to content

fix conditional use of cast sdk #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

chaimPaneth
Copy link
Contributor

What does this Pull Request do?

Adds conditional code only if cast is enabled

Why is this Pull Request needed?

Fixes #9

Are there any points in the code the reviewer needs to double check?

removal of cast events in the main class and added again in an extension

Are there any Pull Requests open in other repos which need to be merged with this?

no

Addresses Issue(s):

#9

GitHub Issue

@chaimPaneth chaimPaneth requested a review from a team as a code owner May 12, 2024 08:28
@Jmilham21 Jmilham21 self-assigned this May 13, 2024
Copy link
Collaborator

@Jmilham21 Jmilham21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing in these updates @chaimPaneth

@Jmilham21 Jmilham21 merged commit d68dc48 into jwplayer:master May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No such module GoogleCast
2 participants