Skip to content

Added .description so onAdEvent returns a string #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

edougher
Copy link
Collaborator

What does this Pull Request do?

This fixes the onAdEvent in the native iOS codebase. It does this by adding .description to the argument so that a string is passed to the RN wrapper. Example:

onAdEvent?(["client": event.client.description, "type": event.type.description])

Why is this Pull Request needed?

When logging the onAdEvent on an iOS device the event was logging null for client and type. For example:

onAdEvent {"client": null, "target": 187, "type": null}

After the fix, the log now looks like this:

onAdEvent {"client": "googima", "target": 187, "type": "request"}

Are there any points in the code the reviewer needs to double check?

No

Are there any Pull Requests open in other repos which need to be merged with this?

No

Addresses Issue(s):

GitHub Issue

@edougher edougher requested a review from Jmilham21 January 29, 2025 22:08
@edougher edougher requested a review from a team as a code owner January 29, 2025 22:08
Copy link
Collaborator

@Jmilham21 Jmilham21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@Jmilham21 Jmilham21 merged commit 2c7747f into master Jan 29, 2025
@Jmilham21 Jmilham21 deleted the bugfix/SDK-11588-onAdEvent branch January 29, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants