Added .description so onAdEvent returns a string #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
This fixes the onAdEvent in the native iOS codebase. It does this by adding .description to the argument so that a string is passed to the RN wrapper. Example:
onAdEvent?(["client": event.client.description, "type": event.type.description])
Why is this Pull Request needed?
When logging the onAdEvent on an iOS device the event was logging null for
client
andtype
. For example:onAdEvent {"client": null, "target": 187, "type": null}
After the fix, the log now looks like this:
onAdEvent {"client": "googima", "target": 187, "type": "request"}
Are there any points in the code the reviewer needs to double check?
No
Are there any Pull Requests open in other repos which need to be merged with this?
No
Addresses Issue(s):
GitHub Issue