Skip to content

[BUG] controls prop and setControls method not working in version 1.1.1 (regression from 1.0.3) #158

Open
@jakubjuraszek

Description

@jakubjuraszek

Describe the bug
The controls prop and the setControls method no longer work in version 1.1.1. This regression breaks dynamic control visibility toggling, which worked correctly in version 1.0.3.

To Reproduce
Use the provided Example application with a minimal setup:

Steps to reproduce the behavior:

Install @jwplayer/[email protected]

Render the component with controls={false}

Try calling playerRef.current.setControls(false) at runtime

Observe that controls are always shown and do not react to the prop or method

Expected behavior

controls={false} should hide player controls

setControls(true/false) should toggle control visibility dynamically at runtime
This worked as expected in version 1.0.3

Screenshots / Visual evidence
Recording attached: [Insert link or drag-and-drop file here, e.g., Loom, mp4, gif]
(Add a short screen recording showing both version 1.0.3 and 1.1.1 for comparison, if possible)

Device(s) affected

Device: e.g., iPhone 14 Pro, Pixel 6

OS: iOS 17.3 / Android 14

JWPlayer version: 1.1.1

Additional context
We rely on toggling player controls programmatically based on app logic (e.g., for fullscreen modes or restricted experiences). The current regression makes this impossible without downgrading the library.

Please let us know if this is an intentional API change or a bug.

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-groomingHas not been reviewed by codeowners for scope/validation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions