Skip to content

JW Demand: Implemented interpretResponse. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jorgeluisrocha
Copy link

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Implemented the interpretResponse function for jwplayerBidAdapter.js.

@jorgeluisrocha jorgeluisrocha changed the title Feature/jwplayer adapter interpret response JW Demand: Implemented interpretResponse. Jun 7, 2022
@jorgeluisrocha jorgeluisrocha force-pushed the feature/jwplayer-adapter-interpretResponse branch from 87ef41a to 4d7fc1b Compare June 28, 2022 20:51
Copy link
Collaborator

@karimMourra karimMourra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response part looks good!

@jorgeluisrocha jorgeluisrocha merged commit ab0a39c into feature/jwplayer-adapter Jun 30, 2022
@jorgeluisrocha jorgeluisrocha deleted the feature/jwplayer-adapter-interpretResponse branch June 30, 2022 20:12
karimMourra pushed a commit that referenced this pull request Jun 4, 2024
* refactors interpretResponse

* updates comment

* simpler

* removes unnecessary comment

* removes more unnecessary comments

* revert ttl

* reverts ttl test values

* revert some || changes

* removes comments

---------

Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
karimMourra pushed a commit that referenced this pull request Jul 9, 2025
…rameters (prebid#13122)

* V 0 29 (#31)

* AGT-403: Add adType parameter to payload in report

* AGT-403: Test for partner report, adType parameter

* AGT-403: Test refactoring

* AGT-403: Documentation updated

* IntentIq Analytics Module: adUnitCode or placemetId to report (#9)

* AGT-446: adUnitCode or placemetId to report

* AGT-446: Description of changes, example

* AGT-446: Fix documentation

* AGT-446: Changes after review

* Agt 409 full url in prebid modules (#8)

* add sync

* update full url

* set url param

* fix comment

* fix issue fix sync mode

* update url

* update full url

* add test

* move browser_blacklist (#10)

* add is optedOut (#11)

* update date in FPD after sync (#12)

* update sync logic for new user (#13)

* fix unit tests

* change version name

* IntentIq ID: Support sourceMetaData and sourceMetaDataExternal (#17)

* AGT-453: Support sourceMetaData

* AGT-453: sourceMetaDataExternal

* AGT-453: Documentation

* AGT-453: Changes after review

* AGT-453: Fix doc

* Fix doc

* AGT-453: Fix test

* update test

* update endpoint (#16)

* update endpoint

* update test

* add tests

* update test

* fix conflict

* fix conflict

* add test for reportingServerAddress

* add test for reportingServerAddress

* AGT-498: support report method parameter (#22)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: reportMethod parameter description (#23)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: Documentation

* Agt 452 server call counters (#18)

* add counters

* add unit tests and fixes

* counters additions

* clear counters when a request is made

---------

Co-authored-by: Eyvaz Ahmadzada <[email protected]>

* add siloEnabled feature (#19)

* add siloEnabled feature

* add siloEnabled feature to analytics adapter

* add unit tests for siloEnabled feature

* add siloenabled to docs

---------

Co-authored-by: Eyvaz Ahmadzada <[email protected]>

* fix unit test issues

* AGT-455: Source parameter in requests (#28)

* AGT-508: Spd parameter (#29)

* AGT-508: Spd parameter

* AGT-508: Move appendSpd to utils

* AGT-499: Support partnerClientIdType and partnerClientId (#30)

* AGT-499: partnerClientId and partnerClientIdType in requests

* AGT-499: Clean comment

* AGT-499: Refactoring

* add groupchanged parameter (#25)

* add groupchanged parameter

* fix md file issue

* add groupChanged example in docs

* remove group from example

* add unit tests and fix groupChanged issue

---------

Co-authored-by: Eyvaz Ahmadzada <[email protected]>
Co-authored-by: DimaIntentIQ <[email protected]>

* Agt 501 support additional params (#24)

* additionalParams feature init

* additional params add features

* additionalparams fix analytics adapter

* add unit tests for additionalParams

* fix currentBrowser issue

---------

Co-authored-by: Eyvaz Ahmadzada <[email protected]>
Co-authored-by: DimaIntentIQ <[email protected]>

* fix linter error

---------

Co-authored-by: dmytro-po <[email protected]>
Co-authored-by: DimaIntentIQ <[email protected]>
Co-authored-by: dLepetynskyiIntentiq <[email protected]>
Co-authored-by: DimaIntentIQ <[email protected]>
Co-authored-by: Eyvaz Ahmadzada <[email protected]>

* fix unit tests (#32)

Co-authored-by: Eyvaz Ahmadzada <[email protected]>

* Agt 547 vr bug for module (#33)

* save progress

* fix calling server

* add "dbsaved" parameter

* add tests

* AGT-552: Additional query params (#34)

* AGT-552: Additional query params

* update documentation

---------

Co-authored-by: DimaIntentIQ <[email protected]>

* Fix unit test for specific browser

* fix spelling

---------

Co-authored-by: Eyvaz <[email protected]>
Co-authored-by: dmytro-po <[email protected]>
Co-authored-by: dLepetynskyiIntentiq <[email protected]>
Co-authored-by: Eyvaz Ahmadzada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants