Skip to content

ref: update the build system to use hatch and update dependency versions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

horw
Copy link
Contributor

@horw horw commented Jan 19, 2025

The Jupyter build system was outdated, so this kernel needs to be migrated to the Hatch build system, which supports shareable files. On the other hand, JupyterLite has been significantly updated, with many new features now available.

The base for this PR was https://github.com/jupyterlite/pyodide-kernel, as it seemed to have been updated quite recently. However, it's too complicated, which is where echo-kernel shines — it provides an easy, not-overwhelming template example.

How to Start Dev Server

nvm use
npm run setup:py
jlpm install
jlpm build
jupyter labextension develop . --overwrite
jupyter lite serve

Further Steps

  • update Readme

Related

Closes #8

@@ -1,24 +0,0 @@
import json
Copy link
Contributor Author

@horw horw Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this file handlers.py isn't needed now?

@horw
Copy link
Contributor Author

horw commented Jan 20, 2025

@jtpio Hello!
What do you think about this migration? Any advice or suggestions for further steps to improve it would be great.
Thanks! Waiting for your response.

@jtpio
Copy link
Member

jtpio commented Jan 20, 2025

Thanks @horw for cleaning this up!

Indeed the repo is a bit outdated.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Left a couple of comments, which will hopefully help with the CI too.

@horw horw force-pushed the ref/update-build-system branch from 1aeafdd to a13b956 Compare February 4, 2025 08:41
@horw
Copy link
Contributor Author

horw commented Feb 4, 2025

@jtpio The previous workflow was outdated as well, so I have updated it. Could you review it?

@jtpio
Copy link
Member

jtpio commented Feb 25, 2025

Thanks @horw.

Looks like there is still an issue with the ESLint.

Wondering if the easiest would be to create a new extension from https://github.com/jupyterlab/extension-template, and simply copy the relevant existing files and config to the new extension, and push everything here?

@horw
Copy link
Contributor Author

horw commented Feb 27, 2025

Thanks @horw.

Looks like there is still an issue with the ESLint.

Wondering if the easiest would be to create a new extension from https://github.com/jupyterlab/extension-template, and simply copy the relevant existing files and config to the new extension, and push everything here?

Thank you! I agree, I will try in a few days

@jtpio
Copy link
Member

jtpio commented Feb 27, 2025

Nice, thanks!

As a heads-up, there is a draft PR in JupyterLite to simplify the current split between regular JupyterLab extensions and the JupyterLite "server" extensions (for example adding a kernel): jupyterlite/jupyterlite#1590

After this PR, adding a kernel (like the echo-kernel) will be like authoring a regular JupyterLab extension. We can keep that echo-kernel as a concrete example of https://github.com/jupyterlab/extension-template, and even consider making it a Github template if folks want to bootstrap their kernel quickly.

@horw
Copy link
Contributor Author

horw commented Apr 28, 2025

@jtpio Thank you! Since you created #10, I'll close this PR.

@horw horw closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation process for development
2 participants