Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter 2.0.1 support #13

Merged

Conversation

itaistopel
Copy link

Hi.

It seems like the installation & the build work well, but instead of searching on files, it doesn't search at all, and shows a part of the commands pellete component.
Could you please take a look?

Thanks.

@parente
Copy link
Member

parente commented Mar 20, 2020

@itaistopel Nice! I'll take a look.

@parente
Copy link
Member

parente commented Mar 20, 2020

I have a couple extra commits that should fix the problem. Can you look for the check box in this pull request view that says "Allow maintainers to push to this branch" or something and make sure it's checked? That will allow me to push the commits to your fork / branch. Thanks!

@itaistopel
Copy link
Author

@parente
Done.
I also added you as a collaborator (I sent an [invitation).

@parente
Copy link
Member

parente commented Mar 20, 2020

@itaistopel Thanks. Checking that checkbox is all that is needed for me to be able to push to your feature branch. No need to grant me access to your whole fork. 👍

I pushed the two commits that seem to have everything working end to end here. Updating the Python jupyterlab dependency to >=2.0.0,<3.0.0a was the main issue. I also added a few more instructions about how to regenerate the poetry lock file to the README after bumping the Python dependencies.

@parente
Copy link
Member

parente commented Mar 20, 2020

I think this is good to go. I'll cut a release of 0.5.0 right after I merge to master. We can iterate in new pull requests if we find issues. Thanks for submitting this one! 🍰

fixes #11

@parente parente merged commit 7259072 into jupyterlab-contrib:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants