Skip to content

Add example LTI 1.1 configuration and readme #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 13, 2021
Merged

Add example LTI 1.1 configuration and readme #54

merged 12 commits into from
Aug 13, 2021

Conversation

jgwerner
Copy link
Collaborator

  • Adds an example LTI 1.1 configuration file in a new examples directory
  • Adds a README to use the example with virtualenv

#53

@jgwerner jgwerner self-assigned this Aug 11, 2021
@jgwerner jgwerner mentioned this pull request Aug 11, 2021
Closed
consideRatio
consideRatio approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM overall, left a comment to summarize what the example was about, but other than that +1 for merge!

@consideRatio
Copy link
Member

Is it correct that this PR doesn't close #53, but that it instead is a way to debug #53 at this point?

@jgwerner
Copy link
Collaborator Author

@consideRatio good point - I'll update the PRs description to not close the issue automatically.

@jgwerner
Copy link
Collaborator Author

@consideRatio I opened #56 to help fix some testing issues with the file provided in the examples folder. If possible, we should merge 56 then I could rebase this one (54) so that GH Actions are green.

@jgwerner
Copy link
Collaborator Author

@consideRatio rebase was completed and tests are passing now. Let me know if you would like me to merge.

@consideRatio consideRatio merged commit b2d9ce6 into jupyterhub:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

@yuvipanda yuvipanda Awaiting requested review from yuvipanda

Assignees

@jgwerner jgwerner

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgwerner @consideRatio