Log out old user when new user logs in #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
yuvipanda
added a commit
to yuvipanda/datahub-old-fork
that referenced
this pull request
Nov 9, 2020
Tests jupyterhub/ltiauthenticator#31 data8x has different 'courses' in EdX that create different 'users' in JupyterHub. This causes problems - if a user logs in from one course, they won't get logged into the *correct* course when they log in from another course! This would log them out of the last session when they log in as a new user. Ref #1725
|
Thanks a lot for this PR, @U4I-fedir-kryvytskyi! I've tested this with the help of @fqzbdkh, and it works! |
|
Congrats on your first merged pull request in this project! 🎉 |
yuvipanda
added a commit
to yuvipanda/ltiauthenticator
that referenced
this pull request
Nov 12, 2020
"Correct" behavior now since jupyterhub#31
Merged
yuvipanda
added a commit
to jupyterhub/tmpauthenticator
that referenced
this pull request
Dec 8, 2020
tmpauthenticator is primarily used in binder-like cases. When a user hits /hub/tmplogin, we want them to get a fresh server. Currently, this could be accomplished with `force_new_server`, which tries to stop a running server (if any) before logging new user in. This has several problems: 1. Stopping servers might fail or take a long time. This shouldn't affect the ability to start new servers. 2. This doesn't work with named servers Instead, we log out the current user first before logging in a new user. This makes everything much faster & cleaner, at the cost of leaving the old user's server running. An idle-culler setup is expected to take care of that. This is the most common & expected behavior, and a break from the earlier defaults. Hence this is a breaking change, requiring a new major version bump. Inspired by jupyterhub/ltiauthenticator#31
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix the existing issue that is described here:
#11
Also there is an existing opened PR for it
#16
But as far as I can see it is quite old, WIP and still opened
More in depth description:
JupyterHub does not set cookies for users after log in if they were previously already set. Which results in situation when attempt of new user to log in via /hub/lti/launch will be discarded if he previously was already logged in under different account