Bump oauthlib dependency #24
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency of oauthlib is too restrictive to work with JupyterHub 1.0.0 or at least the JupyterHub master. ``` ERROR: requests-oauthlib 1.2.0 has requirement oauthlib>=3.0.0, but you'll have oauthlib 2.1.0 which is incompatible. ERROR: jupyterhub 1.0.1.dev0 has requirement oauthlib>=3.0, but you'll have oauthlib 2.1.0 which is incompatible. ``` oauthlib is used very limited in this package it seems, mainly regarding a signature of some kind. The only import made from oauthlib is this this: ``` from oauthlib.oauth1.rfc5849 import signature ``` The changelog: https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst But the changelog didn't capture all breaking changes, so i used git blame: https://github.com/oauthlib/oauthlib/blame/master/oauthlib/oauth1/rfc5849/signature.py Relevant commits: oauthlib/oauthlib@42023d8 oauthlib/oauthlib@0ef0a9c oauthlib/oauthlib@d55944a I renamed some functions, and hope that the signature related changes doesn't break something for someone, but if it does, that this commit message should help them find the related upstream changes.
This was referenced Dec 7, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency of oauthlib is too restrictive to work with JupyterHub
1.0.0 or at least the JupyterHub master.
oauthlib is used very limited in this package it seems, mainly regarding
a signature of some kind. The only import made from oauthlib is this
this:
The changelog:
https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst
But the changelog didn't capture all breaking changes, so i used git blame:
https://github.com/oauthlib/oauthlib/blame/master/oauthlib/oauth1/rfc5849/signature.py
Relevant commits:
oauthlib/oauthlib@42023d8
oauthlib/oauthlib@0ef0a9c
oauthlib/oauthlib@d55944a
I renamed some functions, and hope that the signature related changes
doesn't break something for someone, but if it does, that this commit
message should help them find the related upstream changes.
Related
Closes #23
Closes #21
Closes #19 (it seems likely to me at least, and suggest we reopen it if not)