Fix failure to await render_template #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2021
|
Thanks a lot for fixing this! Any chance this PR will be merged soon? (I am currently trying to decide about which authenticator to deploy and enabling users to change their passwords would be a mandatory feature.) |
consideRatio
changed the title
consideRatio
previously requested changes
Oct 25, 2021
There was a problem hiding this comment.
I think we will require jupyterhub>=1.3 with this change based on whats said in jupyterhub/nativeauthenticator#129.
Can you update setup.py with that new requirement @georgejhunt?
|
My apologies for including the fix for username capitalization. I'll back it out of this PR if you insist. Sometimes git does not behave as I expect. |
coroutine needs to finish before page can be finished when filling out template
|
Rebased to resolve the conflict with #38. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coroutine needs to finish before page can be output.
Update by Erik - 2021-10-26
Closes #36, similar to jupyterhub/nativeauthenticator#129.