Skip to content

add mount type for volume_binds generated mounts #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kreuzert
Copy link

See #536 for more information

@minrk
Copy link
Member

minrk commented May 14, 2025

I think this might be fixed by #535 which lets you pass through all mount arguments without needing any new config fields. Does that work for you?

@kreuzert
Copy link
Author

That's looking interesting. This might fix the issue for persistent user storage volumes. But I'm not sure it will solve the issue for "internal-ssl-certs" volumes. They're not configured previously by the config, so I cannot configure the required mount arguments.

Or am I missing an option to mount the ssl volume with different arguments?

@minrk
Copy link
Member

minrk commented May 14, 2025

right, that makes sense. I wonder if there's a better passthrough here, because in general I want to avoid exposing underlying options one at a time if it's avoidable, and instead let you passthrough things directly to the docker API.

Do you think there's perhaps an equivalent to #535 for swarm mounts? Does it work to specify type via volume_driver_options and remove type from the Mount kwargs?

Re-reading a bit, I think maybe the type='bind' is actually just wrong for swarm, though it works in single-node tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants