Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SAS codestub and autograde for metakernel based non-python kernels #1356

Merged
merged 14 commits into from
Sep 15, 2020

Conversation

jld23
Copy link
Contributor

@jld23 jld23 commented Aug 10, 2020

similar to #870 I've added a code stub to get people started using nbgrader for teaching SAS.
This is a one line change.

The more consequential change is supporting auto-grading when cells return as a stream and then output.name is stderr.
This issue was discussed in #1173 specifically for octave and @jhamrick indicated support for a change to compare output.output_type == "stream" and output.name == "stderr":

This change is useful because it allows the many non-Python language kernels based on metakernel, not just octave, to integrate with nbgrader if they use the metakernel Error or Error_display methods.

@jld23 jld23 changed the title add SAS codestub and add SAS codestub and autograde for metakernel based non-python kernels Aug 10, 2020
@jld23
Copy link
Contributor Author

jld23 commented Aug 10, 2020

I've never used codecov before it appears the check is failing on my typo commit. I'm not sure how to remediate.

@jld23
Copy link
Contributor Author

jld23 commented Sep 10, 2020

Is there anything needed from me to advance this PR?

@BertR
Copy link
Contributor

BertR commented Sep 11, 2020

Hi @jld23, thanks for this! The change looks good to me. I can't figure out why the Windows build is failing, but it might not have anything to do with your PR. Would you be able to check your code on a Windows environment?

@BertR BertR self-assigned this Sep 11, 2020
@BertR BertR added this to the 0.6.2 milestone Sep 11, 2020
@jld23
Copy link
Contributor Author

jld23 commented Sep 14, 2020

@BertR, I got a windows system working and I can confirm I'm seeing issues with 0.7.0.dev0 (my PR branch) and not with pip installed 0.6.1 I'm getting errors where I don't think my code is involved like updating the notebooks nbgrader update source.

Not sure how you want to proceed.

@BertR
Copy link
Contributor

BertR commented Sep 15, 2020

@BertR, I got a windows system working and I can confirm I'm seeing issues with 0.7.0.dev0 (my PR branch) and not with pip installed 0.6.1 I'm getting errors where I don't think my code is involved like updating the notebooks nbgrader update source.

Not sure how you want to proceed.

@jld23 it's possible this failed due to broken pypi dependencies in the master branch which have now been fixed.
Could you rebase and push again?

@BertR BertR merged commit ed98bc9 into jupyter:master Sep 15, 2020
BertR added a commit that referenced this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants