-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SAS codestub and autograde for metakernel based non-python kernels #1356
Conversation
I've never used |
Fix migration, grade cells were looking for a non-existing column
Is there anything needed from me to advance this PR? |
Hi @jld23, thanks for this! The change looks good to me. I can't figure out why the Windows build is failing, but it might not have anything to do with your PR. Would you be able to check your code on a Windows environment? |
@BertR, I got a windows system working and I can confirm I'm seeing issues with 0.7.0.dev0 (my PR branch) and not with pip installed 0.6.1 I'm getting errors where I don't think my code is involved like updating the notebooks Not sure how you want to proceed. |
Pin nbconvert to 5.6.1, traitlets to 4.3.3 and pytest to <6.0.0
@jld23 it's possible this failed due to broken pypi dependencies in the master branch which have now been fixed. |
similar to #870 I've added a code stub to get people started using nbgrader for teaching SAS.
This is a one line change.
The more consequential change is supporting auto-grading when cells return as a stream and then
output.name
isstderr
.This issue was discussed in #1173 specifically for octave and @jhamrick indicated support for a change to compare
output.output_type == "stream" and output.name == "stderr":
This change is useful because it allows the many non-Python language kernels based on metakernel, not just octave, to integrate with nbgrader if they use the metakernel
Error
orError_display
methods.