Fix last one hardcoded unversioned python command

[frenzymadness]

I'm sorry, it seems that I missed this one. I've prepared this PR in a browser so please test it before merging.

[frenzymadness]

I'd like to debug the issue but I don't have an access to a machine with windows. But it seems that it cannot handle the full path to executable. It might make sense to omit the call to which if the first part of the command is an absolute path.

[afshin]

It might make sense to omit the call to which if the first part of the command is an absolute path.

This sounds reasonable 👍

[frenzymadness]

I might try to implement it but I don't have a windows machine to test it.

[frenzymadness]

Implemented in the last commit.

[afshin]

It looks like the path fix needs to be on sys.executable itself. You shouldn't need any changes to setupbase.py if you make only these changes:

diff --git a/tests/test_utility_functions.py b/tests/test_utility_functions.py
index 334c085..ea8127e 100644
--- a/tests/test_utility_functions.py
+++ b/tests/test_utility_functions.py
@@ -1,4 +1,5 @@
-
+import os
+import sys
 from unittest.mock import patch
 import pytest

@@ -28,7 +29,8 @@ def test_combine_commands():


 def test_run():
-    assert pkg.run('python --version') == 0
+    python = sys.executable.replace(os.sep, '/')
+    assert pkg.run(f'{python} --version') == 0

     with pytest.raises(ValueError):
         pkg.run('foobarbaz')

[frenzymadness]

It looks like the path fix needs to be on sys.executable itself. You shouldn't need any changes to setupbase.py if you make only these changes:

But I still don't know why should I change the path separators from Windows to Linux. I'd say that windows paths should work on windows.

[afshin]

In this case the limitation is shutil.which not handling the Windows path, part of the standard library. Windows support is best-effort, since none of the core devs are Windows users.

[vidartf]

Windows support is best-effort, since none of the core devs are Windows users.

👋

I added a commit to the PR to resolve the issue: It was using shlex.split which seems to need a posix=False on Windows to not bork windows paths.

NB: Another solution would have been to pass [sys.executable, "--version"] instead of passing a string.

[blink1073]

Thanks @frenzymadness and @vidartf!