feat: add skip_if_exists command to skip when paths exists #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released as 0.7.6. |
This was referenced Dec 16, 2020
jtpio
reviewed
Dec 18, 2020
| return any(not Path(path).exist() for path in paths) | ||
| class SkipIfExistCommand(Command): | ||
| def initialize_options(self): | ||
| if not should_skip: |
There was a problem hiding this comment.
Shouldn't this be?
if not should_skip():There was a problem hiding this comment.
Good catch, and all(Path(path).exist() for path in paths) should improve readability
There was a problem hiding this comment.
Also wondering about the logic here.
Shouldn't the command be run (= not skipped) in case any of the files is missing?
Wondering whether this could be:
def should_run():
return any(not Path(path).exist() for path in paths)And then:
if should_run():
self.command = CommandClass(self.distribution)
self.command.initialize_options()
else:
self.command = NoneThere was a problem hiding this comment.
OK I can submit a follow-up PR then.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming from bqplot/bqplot#1235 to make source package skip the npm build step. Note, I cannot test this, because I don't know how. Since running pip install will fetch jupyter_packaging from pypi, how can I use my local dev install? cc @martinRenou