Allow --prefix to work #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes a change from `sys.prefix` to `self.prefix` to allow top-level command to set the prefix. Still doesn't work with `--user`, but maybe that can be fixed in this PR too.
|
There are some things I don't understand about how setup works, removing files, --user, and --prefix. There may be more than what this PR does that is needed. |
This takes care of: * read-only dirs * --prefix * --install_dir * --prefix
|
Ok, I think this is the correct fix. |
Sometimes install_base just isn't set for some reason
There may be a third issue, but I can't figure it out. Perhaps this is just a hacky way to use seuptools, or setuptools has issues.
|
Thanks @dsblank! |
|
Thanks folks, and welcome back @blink1073 ! Hope all is going well. Re: this PR... there are probably better ways of handling setuptools, and maybe an expert will look at this someday. But it is working for me when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a change from
sys.prefixtoself.install_baseto allow top-level command to set the --prefix or --install_dir.