Data spec path issues #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

blink1073 merged 3 commits into jupyter:master from vidartf:paths

Jan 31, 2018

Collaborator

vidartf commented Jan 31, 2018

Adds a some tests for _get_data_files(), some of which fail.
Fixes related issues.
Adds appveyor config. After enabling appveyor for this repo, this should ensure that the tests are also run on Windows platform, which is needed to avoid pathing regressions when using backslash as pathing separator.

vidartf added 3 commits

January 31, 2018 15:24


          Add tests for _get_data_files


          Fix for path errors

e374cc2


          Add appveyor CI config

0255d5f

Contributor

blink1073 commented Jan 31, 2018

LGTM, thanks!

blink1073 merged commit cfec410 into jupyter:master

vidartf deleted the paths branch

January 31, 2018 16:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet