Skip to content

Add basic tests + fixes for find_packages #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2017
Merged

Add basic tests + fixes for find_packages #14

merged 3 commits into from
Apr 21, 2017

Conversation

vidartf
Copy link
Collaborator

@vidartf vidartf commented Apr 21, 2017 •
edited
Loading

Is there a reason why we roll our own find_packages instead of relying on setuptools'?

@vidartf vidartf mentioned this pull request Apr 21, 2017
Merged
@blink1073 blink1073 merged commit 5a89d1d into jupyter:master Apr 21, 2017
@vidartf vidartf deleted the fix-find-packages branch April 21, 2017 15:17
@blink1073
Copy link
Contributor

Ah, I just saw the question. Perhaps it was there because we previously weren't relying on setuptools.

@blink1073
Copy link
Contributor

blink1073 commented Apr 21, 2017 •
edited
Loading

Looking at the setuptools.find_packages source, I don't see a reason not to switch.

@vidartf
Copy link
Collaborator Author

vidartf commented Apr 21, 2017

Yes, this PR was simply a fix in case there was a reason to keep it. Will we still export it, or should packages import directly from setuptools?

@blink1073
Copy link
Contributor

I'd say remove it here.

@vidartf
Copy link
Collaborator Author

vidartf commented Apr 21, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vidartf @blink1073