feat: replace fsWatch by chokidar #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On one hand, there was an issue when re-adding .wasm or .mjs files to the /target/deploy folder—those changes weren’t detected. Deleting a file and then adding it again, even if the build was different, didn’t trigger a new deploy.
On the other hand, there was also a strange issue: if an exception occurred in a watcher, the watcher would stop entirely, even though the errors were properly caught. This was problematic, as developers had to restart their environment to build and deploy again.
Long story short, using Chokidar resolved both issues.