Skip to content

Update README.md #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

WalterMadelim
Copy link

No description provided.

@odow
Copy link
Member

odow commented May 11, 2025

Was there some confusion here? It must be the ::String "false", not the ::Bool false.

@odow
Copy link
Member

odow commented May 11, 2025

Closing as won't fix. I don't think we should make this change.

@odow odow closed this May 11, 2025
@WalterMadelim
Copy link
Author

In win11, I set like this.
image

The point here is that you've used the code quote KEY, VALUE all time. The existing description is KEY, "VALUE". There is no need to use a further plain quote like "VALUE", which looks inconsistent.

The description could be

  1. KEY, VALUE
  2. "KEY", "VALUE",
    or if you don't find troublesome
  3. "KEY", "VALUE"

@odow
Copy link
Member

odow commented May 11, 2025

Did you see the code block below? You don't need to use the Windows GUI.

If we don't use ", then there is an ambiguity between ::String and ::Bool.

Now admittedly, it doesn't really matter because Julia automatically converts:

julia> ENV["ABC"] = false
false

julia> ENV["ABC"]
"false"

I think the style of unquoted = quoted is fairly standard. See, e.g., https://docs.julialang.org/en/v1/manual/environment-variables/.

It's not even Julia specific. You might do:

export GUROBI_JL_USE_GUROBI_JLL="false"; julia -e "import Pkg; Pkg.add(\"Gurobi\")"

Unquoted on the left. Quoted on the right.

@WalterMadelim WalterMadelim deleted the patch-1 branch May 12, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants