Skip to content

Change DualObjectiveValue to use Utilities.get_fallback #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

odow
Copy link
Member

@odow odow commented Mar 14, 2025

@blegat: I'm not really sure what we originally intended here.

help?> MOI.DualObjectiveValue
  DualObjectiveValue(result_index::Int = 1)

  A model attribute for the value of the objective function of the dual problem for the result_indexth dual result.

  If the solver does not have a dual value for the objective because the result_index is beyond the available solutions (whose number is indicated by the ResultCount attribute), getting this attribute
  must throw a ResultIndexBoundsError. Otherwise, if the result is unavailable for another reason (for instance, only a primal solution is available), the result is undefined. Users should first check
  DualStatus before accessing the DualObjectiveValue attribute.

  See ResultCount for information on how the results are ordered.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (6e12c8a) to head (757559c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   93.55%   93.87%   +0.32%     
==========================================
  Files           6        6              
  Lines        2715     2710       -5     
==========================================
+ Hits         2540     2544       +4     
+ Misses        175      166       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow odow merged commit ce963bd into master Mar 15, 2025
23 checks passed
@odow odow deleted the od/dual-objective-value branch March 15, 2025 03:45
@blegat
Copy link
Member

blegat commented Mar 16, 2025

It should be the dual objective evaluated at the dual solution so it's indeed not the objective bound of MIPs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants