[Android] Optimize Secure Storage by Replacing Single Worker Thread with Thread Pool #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @juliansteenbakker, please can you take a look?🙏🏾 |
|
@juliansteenbakker Hii...👀 |
|
So sorry for the delay, im on vacation till friday, will take a look when i get back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Secure storage operations were previously executed on a single worker thread. This becomes a bottleneck when multiple read operations are triggered simultaneously, leading to significant delays due to the synchronous execution on the native side.
Solution
Replaced the single worker thread with a thread pool (using Executors.newCachedThreadPool()). This allows multiple secure storage operations to run concurrently, significantly improving performance when handling simultaneous read/write requests.
Impact
Reduces contention and latency for secure storage operations.
Improves app responsiveness when multiple storage operations are triggered.
No changes in API usage—just an internal optimization for Android.