Skip to content

more wait, more retry #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

kradalby
Copy link
Collaborator

From my lengthy comment for rational:

    ⋮ 130│          # Our integration tests are started like a thundering herd, often
    ⋮ 131│          # hitting limits of the various external repositories we depend on
    ⋮ 132│          # like docker hub. This will retry jobs every 5 min, 10 times,
    ⋮ 133│          # hopefully letting us avoid manual intervention and restarting jobs.
    ⋮ 134│          # One could of course argue that we should invest in trying to avoid
    ⋮ 135│          # this, but currently it seems like a larger investment to be cleverer
    ⋮ 136│          # about this.
    ⋮ 137│          # Some of the jobs might still require manual restart as they are really
    ⋮ 138│          # slow and this will cause them to eventually be killed by Github actions.

Signed-off-by: Kristoffer Dalby <[email protected]>
Copy link

review-ai-agent bot commented Apr 16, 2025

Pull Request Revisions

RevisionDescription
r1
GitHub workflow retry configurations updatedModified integration test workflows to increase retry attempts and add a 5-minute delay between retries for handling external repository limitations
✅ AI review completed for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kradalby kradalby merged commit 0fbe392 into juanfont:main Apr 16, 2025
276 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants