Skip to content

feat: Add autogroup ACLs #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

gabe565
Copy link
Contributor

@gabe565 gabe565 commented Nov 8, 2024

I have taken @vinhjaxt's autogroup implementation from #657 (comment), added some code improvements, fixed lint, and added tests. This is still a WIP, but so far it's working as intended.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #657

@gabe565 gabe565 marked this pull request as draft November 8, 2024 18:48
@kradalby
Copy link
Collaborator

kradalby commented Nov 8, 2024

Im on holiday so wont have time to take a look for a few weeks but wanted to just jump in and say that I have started work to redo the policy code, there is a draft pr, but its very draft pending many changes.

I don't imagine I would add anything new to the policy as is, so this should be added on top of the new work. That said it might not be in the final state and it might be hard to do so yet.

I do appreciate you picking this up, and would love to see it in when we get there.

@AdamsGH
Copy link

AdamsGH commented Dec 30, 2024

Really waiting for this feature!

@danscarfe
Copy link

Hey, any update here. Really looking forward to this function and kind of blocked without it (without changing from using main image)

@vdovhanych
Copy link
Contributor

I have reimplemented this in policy v2 and will test it more in my home lab environment to see if it's working as expected. It's pretty much the same logic as the code here, but it is done in the way policy v2 is written.

@kradalby
Copy link
Collaborator

kradalby commented Apr 3, 2025

Sounds sensible, main criteria is tests, happy also to help with it as we want to get there eventually, but might say thst we want to wait one release with this one

@danscarfe

This comment has been minimized.

@kradalby
Copy link
Collaborator

kradalby commented May 4, 2025

https://github.com/juanfont/headscale/releases/tag/v0.26.0-beta.1, new beta is out, I think it should be fairly safe to rebase this onto that branch and if we get it proper tested it should be something we can get into 0.27.

Targeting 0.27, no v1 code needs to be considered.

@kradalby
Copy link
Collaborator

I'm going to close this in favour of @vdovhanych's PR, and some collaborations on getting this in as this PR is out of date.

@kradalby kradalby closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for "autogroup:" in ACL rules
6 participants