Skip to content

swap rweb-cssom to @acemir/cssom for better css nesting support #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

acemir
Copy link

@acemir acemir commented Jul 19, 2025

The updated dependency package enhances the parser's ability to correctly process complex CSS structures, including nested selectors, nested declarations, layer statements and at-rules validations.

Key Changes

Introducing CSS Nesting Module support

Improved At-Rule Validation

  • Refactored at-rule validation logic ensuring that invalid or malformed at-rules are ignored more reliably.
  • Improved handling of edge cases, such as unbalanced braces and complex at-rule conditions.
  • Enhanced handling of at-rules that cannot be nested.

Improvements in CSS Cascading

@acemir
Copy link
Author

acemir commented Jul 19, 2025

Closes #3885

@domenic
Copy link
Member

domenic commented Jul 19, 2025

Exciting! Please add a comment when you get the test suite passing, including making sure there is web platform test coverage for all the new functionality.

@acemir acemir marked this pull request as draft July 19, 2025 21:06
@acemir acemir force-pushed the fix/swap-cssom-with-improvements branch 8 times, most recently from 589168e to a98576a Compare July 25, 2025 02:41
@acemir
Copy link
Author

acemir commented Jul 25, 2025

Current tests are passing. Now we could look for some coverage increase.

@acemir acemir marked this pull request as ready for review July 25, 2025 08:58
@acemir acemir force-pushed the fix/swap-cssom-with-improvements branch from a98576a to e5e6084 Compare July 25, 2025 10:50
@acemir acemir force-pushed the fix/swap-cssom-with-improvements branch from e5e6084 to 917da36 Compare July 25, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants