Update to latest test262 and pull recent changes from upstream #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of doing a multiplication here, we can just check if the remainder is zero. This matters a bit more for TimeDuration and RoundNumberToIncrementAsIfPositive, because we avoid a BigInt multiplication. UPSTREAM_COMMIT=407adc9e221eecb97e4db1c7b2b8e2b41cbea29a
For a few time zones, the two-week search window for an interval to bisect is too large, because transitions occur less than two weeks apart. Special-case these time zones. This allows increasing the default window to 19 days (a bunch of Argentinian time zones have transitions less than 20 days apart, so this seems like a good boundary where we don't have to add too many special cases.) This gives a small performance improvement in the common case. UPSTREAM_COMMIT=da53e9acead66c3616971e487236bde1a731c564
This is currently unspecified behaviour, and is to be specified later in tc39/proposal-intl-era-monthcode#15 Closes: #3096 UPSTREAM_COMMIT=2e156ecb102cd4e1c93b21b26f2611832f6499de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.