Skip to content

IntelGPU: add device support for widedeep models #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

weishi-deng
Copy link

To evaluate the accuracy and performance on xpu devices, this PR aims to add device support for wide&deep models.

@weishi-deng weishi-deng marked this pull request as draft July 4, 2025 08:46
@jrzaurin jrzaurin self-requested a review July 4, 2025 08:47
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.86%. Comparing base (a4ac1d6) to head (9cceba5).

Files with missing lines Patch % Lines
pytorch_widedeep/utils/general_utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   94.87%   94.86%   -0.02%     
==========================================
  Files         126      126              
  Lines        8277     8280       +3     
==========================================
+ Hits         7853     7855       +2     
- Misses        424      425       +1     
Flag Coverage Δ
unittests 94.86% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrzaurin jrzaurin marked this pull request as ready for review July 4, 2025 09:24
Copy link
Owner

@jrzaurin jrzaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only test that fails is code style, which is fine

Happy to merge and thanks for opening the PR!

@jrzaurin
Copy link
Owner

jrzaurin commented Jul 4, 2025

Thanks for opening the PR! (I don't have much time to maintain this these days, but I will be back!)

The tests that fail are only style ones, so all cool, is fine.

please, feel free to merge!

@jrzaurin
Copy link
Owner

jrzaurin commented Jul 5, 2025

@weishi-deng

Before you merge make sure you re-base or merge the new master (I will eventually re-name it to main :) ) into your branch. I have updated the unit tests to function with torch 2.6 or later.

Otherwise you will experience merge conflicts

@jrzaurin
Copy link
Owner

jrzaurin commented Jul 8, 2025

tests are failing once I updated to support newer versions of torch, if you wanted to merge we would need to fix those. I will have a look asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants