Skip to content

fix: fix dayjs localizer merge function to not change min and max #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

7assenTlili
Copy link
Contributor

@7assenTlili 7assenTlili commented Jan 21, 2025

Fixes #2688

Fixes dayjs localizer merge function so min and max of the day stays always the same.

@milkman4
Copy link
Contributor

@cutterbl this would be a big help in our production app, if you're able to take a peek!

@milkman4
Copy link
Contributor

Any chance we can get this merged @cutterbl ? :)

@stampycode
Copy link

Would appreciate a merge! Thanks @cutterbl

Hope this will fix issue shown in image...
image

@cutterbl cutterbl merged commit 7d2aa77 into jquense:master May 28, 2025
github-actions bot pushed a commit that referenced this pull request May 28, 2025
## [1.19.2](v1.19.1...v1.19.2) (2025-05-28)

### Bug Fixes

* fix dayjs localizer merge function to not change min and max upon tz change ([#2712](#2712)) ([7d2aa77](7d2aa77))
Copy link

🎉 This PR is included in version 1.19.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dattran1232003
Copy link

Hello guys, I guess this PR causes this problem:

On localhost, the time slots match min/max I pass to component's prop
image

But it displays wrong when I build it on to production
image

I think this is because production uses version 1.19.2, while on localhost I use 1.15.0 (I don't install with lockfile immutable)

If I inspect the outer component, I see localhost props and production props are the same, which means there's some internal conversion that makes the time display wrong
image
image


I can confirm version 1.15.0 don't have this, I've revert the code and it works well
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DayJS Localizer - Setting default timezone does not adjust min/max correctly in TimeGrid
5 participants