Skip to content

Empty arrays join/1 to an empty string, fixes #668 bug introduced by 9760245 #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2015
Merged

Empty arrays join/1 to an empty string, fixes #668 bug introduced by 9760245 #669

merged 1 commit into from
Jan 14, 2015

Conversation

joelpurra
Copy link
Contributor

Commit 9760245 would return null when joining an empty array.

@joelpurra joelpurra mentioned this pull request Jan 14, 2015
Closed
nicowilliams added a commit that referenced this pull request Jan 14, 2015
@nicowilliams
Merge pull request #669 from joelpurra/join-empty-array-668
cca3e92 
Empty arrays join/1 to an empty string, fixes #668 bug introduced by 9760245
@nicowilliams nicowilliams merged commit cca3e92 into jqlang:master Jan 14, 2015
@nicowilliams nicowilliams added this to the 1.5 release milestone Jan 14, 2015
@joelpurra joelpurra deleted the join-empty-array-668 branch January 14, 2015 22:51
@joelpurra
Copy link
Contributor Author

@nicowilliams: thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.5 release
Development

Successfully merging this pull request may close these issues.
2 participants
@joelpurra @nicowilliams