Fix --indent 0 implicitly enabling compact-output

[amarshall]

Now it will retain pretty-printing, just removing any indentation. Fixes #1465 and fixes #2498.

[coveralls]

Coverage increased (+0.4%) to 84.509% when pulling bedc1ff on amarshall:fix-indent-zero into 80052e5 on stedolan:master.

[amarshall]

@itchyny I would argue this is a bug fix, not a feature request. The manpage doesn’t document the prior behavior, and --indent 0 behaves completely differently from any other value. That said, I understand someone, somewhere might be relying on the prior functionality. Ultimately it’s the decision of maintainers, I don’t mind either way.

[itchyny]

Okay, rebase this PR, please. Also tests are needed.

[nicowilliams]

Hmm, how do I approve the actions to run on this PR?

[wader]

@nicowilliams i'm guessing it needs a new push to run

[PatMyron]

Closing + re-opening PRs also kicks off PR checks

[wader]

Seems to break --indent 1

$ ./jq --indent 0 -n '[{a:1}]'
[
{
"a": 1
}
]
$ ./jq --indent 1 -n '[{a:1}]'
[{"a":1}]
$ ./jq --indent 2 -n '[{a:1}]'
[
  {
    "a": 1
  }
]

Maybe this is also an indication we should have some tests for indent/compact flags?

[gbrlmarn]

Hello, I've created a pr #3202 with tests regarding this pull request.

[itchyny]

Seems to break --indent 1

I don't reproduce the issue. Seems working.

BTW (n) == 0 check is not necessary anymore because (0) << 8 is 0.

[wader]

@itchyny hmm strange but good i guess :) maybe we should merge the tests from #3202 into this PR?