Compilation fails with feature `bevy_ecs/track_change_detection`

[Seldom-SE]

On main, cargo b --features bevy_ecs/track_change_detection fails with

error[E0061]: this function takes 6 arguments but 5 arguments were supplied
   --> bevy-trait-query/src/one/impls/one.rs:181:9
    |
181 |           Ref::new(
    |  _________^^^^^^^^-
182 | |             dyn_ctor.cast(ptr),
183 | |             added,
184 | |             changed,
185 | |             fetch.last_run,
186 | |             fetch.this_run,
187 | |         )
    | |_________- argument #6 of type `&'static Location<'static>` is missing
    |
note: associated function defined here
   --> /home/seldom/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.1/src/change_detection.rs:775:12
    |
775 |     pub fn new(
    |            ^^^
help: provide the argument
    |
181 |         Ref::new(dyn_ctor.cast(ptr), added, changed, fetch.last_run, fetch.this_run, /* &'static Location<'static> */)
    |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0061]: this function takes 6 arguments but 5 arguments were supplied
   --> bevy-trait-query/src/all/core/read.rs:76:14
    |
76  |           Some(Ref::new(
    |  ______________^^^^^^^^-
77  | |             trait_object,
78  | |             added_tick,
79  | |             changed_tick,
80  | |             self.last_run,
81  | |             self.this_run,
82  | |         ))
    | |_________- argument #6 of type `&'static Location<'static>` is missing
    |
note: associated function defined here
   --> /home/seldom/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.1/src/change_detection.rs:775:12
    |
775 |     pub fn new(
    |            ^^^
help: provide the argument
    |
76  |         Some(Ref::new(trait_object, added_tick, changed_tick, self.last_run, self.this_run, /* &'static Location<'static> */))
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0061]: this function takes 6 arguments but 5 arguments were supplied
   --> bevy-trait-query/src/one/impls/one.rs:394:9
    |
394 |           Mut::new(
    |  _________^^^^^^^^-
395 | |             dyn_ctor.cast_mut(ptr),
396 | |             added,
397 | |             changed,
398 | |             fetch.last_run,
399 | |             fetch.this_run,
400 | |         )
    | |_________- argument #6 of type `&mut &'static Location<'static>` is missing
    |
note: associated function defined here
   --> /home/seldom/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.1/src/change_detection.rs:894:12
    |
894 |     pub fn new(
    |            ^^^
help: provide the argument
    |
394 |         Mut::new(dyn_ctor.cast_mut(ptr), added, changed, fetch.last_run, fetch.this_run, /* &mut &'static Location<'static> */)
    |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0061]: this function takes 6 arguments but 5 arguments were supplied
   --> bevy-trait-query/src/all/core/write.rs:86:14
    |
86  |           Some(Mut::new(
    |  ______________^^^^^^^^-
87  | |             trait_object,
88  | |             added,
89  | |             changed,
90  | |             self.last_run,
91  | |             self.this_run,
92  | |         ))
    | |_________- argument #6 of type `&mut &'static Location<'static>` is missing
    |
note: associated function defined here
   --> /home/seldom/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.1/src/change_detection.rs:894:12
    |
894 |     pub fn new(
    |            ^^^
help: provide the argument
    |
86  |         Some(Mut::new(trait_object, added, changed, self.last_run, self.this_run, /* &mut &'static Location<'static> */))
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0061]: this function takes 6 arguments but 5 arguments were supplied
   --> bevy-trait-query/src/all/core/read.rs:112:14
    |
112 |           Some(Ref::new(
    |  ______________^^^^^^^^-
113 | |             trait_object,
114 | |             added_tick,
115 | |             changed_tick,
116 | |             self.last_run,
117 | |             self.this_run,
118 | |         ))
    | |_________- argument #6 of type `&'static Location<'static>` is missing
    |
note: associated function defined here
   --> /home/seldom/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.1/src/change_detection.rs:775:12
    |
775 |     pub fn new(
    |            ^^^
help: provide the argument
    |
112 |         Some(Ref::new(trait_object, added_tick, changed_tick, self.last_run, self.this_run, /* &'static Location<'static> */))
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0061]: this function takes 6 arguments but 5 arguments were supplied
   --> bevy-trait-query/src/all/core/write.rs:135:14
    |
135 |           Some(Mut::new(
    |  ______________^^^^^^^^-
136 | |             trait_object,
137 | |             added,
138 | |             changed,
139 | |             self.last_run,
140 | |             self.this_run,
141 | |         ))
    | |_________- argument #6 of type `&mut &'static Location<'static>` is missing
    |
note: associated function defined here
   --> /home/seldom/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_ecs-0.15.1/src/change_detection.rs:894:12
    |
894 |     pub fn new(
    |            ^^^
help: provide the argument
    |
135 |         Some(Mut::new(trait_object, added, changed, self.last_run, self.this_run, /* &mut &'static Location<'static> */))
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

For more information about this error, try `rustc --explain E0061`.
error: could not compile `bevy-trait-query` (lib) due to 6 previous errors

[RobWalt]

Thanks for finding that 🙏 I'll update main soonish!

[RobWalt]

I just took a look at it and it is not as simple. I'd like to wait what comes out of bevyengine/bevy#17602 before starting any efforts here that are not needed anymore in one week or so. I hope that is ok for you @Seldom-SE ? Otherwise we can look for solutions and workarounds to help you out.

[Seldom-SE]

Yes, that's okay. If I need the feature again before then, I can hack a (compiling, but not necessarily correct) solution into a fork, and that'd be good enough for me.

[blueforesticarus]

Hacking a compiling fork doesn't seem trivial either. Mut::new wants a &mut &Location

Edit: it was actually easier to just provide the correct value instead of a dummy. I'm ~80% sure the unsafe blocks I copy pasted are kosher.