Fix double printing of spec descriptions #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ert-equal-including-properties is marked as obsolete from Emacs 29.1, replaced by equal-including-properties. Unfortunately, equal-including-properties in Emacs 28.X does not work for us, so don't switch to the equal-including-properties unless ert-equal-including-properties is marked as obsolete.
Add a spy to current-time in the "When using quiet specs in the batch reporter" suite so that the printed report can be checked with :to-equals instead of :to-match.
… color Refactor the test so each spec becomes a suite of two specs doint the same test with and without color enabled. This exposes the bug described in jorgenschaefer#251
The spec descriptions would be printed twice when buttercup-reporter-batch-quiet-statuses is non-empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251